[PR #2444/29bc71db backport][0.20] Mark distribution update/delete as non-immediate#2448
Open
patchback[bot] wants to merge 1 commit into0.20from
Conversation
AnsibleDistribution lifecycle hooks trigger heavy index rebuilds via _update_index(), so update and delete should not be dispatched with immediate=True. Set ALLOW_NON_BLOCKING_UPDATE and ALLOW_NON_BLOCKING_DELETE to False on AnsibleDistributionViewSet. Fixes #2445 (cherry picked from commit 29bc71d)
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #2444 as merged into main (29bc71d).
AnsibleDistribution lifecycle hooks trigger heavy index rebuilds, so update and delete should not be dispatched with
immediate=True. Pulpcore exposes the control of whether this can be run immediately viaALLOW_NON_BLOCKING_UPDATEandALLOW_NON_BLOCKING_DELETE.Fixes #2445
📜 Checklist
See: Pull Request Walkthrough